Add tests for duplicate additional_variables/copy_variables in normal… #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
even though this is caught now, it is sort of just an fortunate "accident" that we now check for duplicate columns later in the process of loading an entity. I'd say it is still worth it to add a check in Want to add that? the test cases look good though |
|
Ah, ok-- Yeah I'm down to add the more specific errors. |
georgewambold
force-pushed
the
add_duplicate_columns_custom_error
branch
from
5b01742
to
4414ffe
Compare
|
Looks good, merging. Thanks for the contribution, we appreciate it! |
jeff-hernandez
pushed a commit
to jeff-hernandez/featuretools
that referenced
this pull request
Dec 14, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…ize_entity