Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codecov reports #359

Merged
merged 2 commits into from Dec 20, 2018
Merged

Fix codecov reports #359

merged 2 commits into from Dec 20, 2018

Conversation

rwedge
Copy link
Collaborator

@rwedge rwedge commented Dec 20, 2018 •
edited

fixes #358

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@7a48c4f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #359   +/-   ##
=========================================
  Coverage          ?   95.31%           
=========================================
  Files             ?       86           
  Lines             ?     8027           
  Branches          ?        0           
=========================================
  Hits              ?     7651           
  Misses            ?      376           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a48c4f...fc5b57e. Read the comment docs.

@rwedge rwedge requested a review from kmax12 December 20, 2018 16:37
kmax12
kmax12 approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwedge rwedge merged commit 5592d05 into master Dec 20, 2018
@rwedge rwedge mentioned this pull request Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmax12 kmax12 kmax12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: codecov missing
2 participants
@rwedge @kmax12