Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable type in demo data #37

merged 1 commit into from Dec 1, 2017

Fix variable type in demo data #37

merged 1 commit into from Dec 1, 2017


Copy link

@kmax12 kmax12 commented Dec 1, 2017

Explicitly specify that zip code is a categorical value in mock customer dataset

Copy link

Codecov Report

Merging #37 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #37      +/-   ##
+ Coverage    88.1%   88.1%   +<.01%     
  Files          71      71              
  Lines        6791    6792       +1     
+ Hits         5983    5984       +1     
  Misses        808     808
Impacted Files Coverage Δ
featuretools/demo/ 16.66% <100%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8162e74...1ad616a. Read the comment docs.

Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kmax12 kmax12 merged commit da5637b into master Dec 1, 2017
@kmax12 kmax12 mentioned this pull request Dec 12, 2017
@kmax12 kmax12 deleted the fix_demo_vtype branch December 20, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants