Add primitive.get_filepath and example of primitive loading data from external files #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 95.84% 95.85% +0.01%
==========================================
Files 89 89
Lines 7769 7798 +29
==========================================
+ Hits 7446 7475 +29
Misses 323 323
Continue to review full report at Codecov.
|
kmax12
reviewed
Jan 25, 2019
|
|
||
| def test_get_data_path(es): | ||
| class Mod4(TransformPrimitive): | ||
| '''Replace each integer with a word from a shakespearean sonnet''' |
There was a problem hiding this comment.
is this docstring accurate?
rwedge
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds the method
PrimitiveBase.get_filepath. This helper function creates an absolute file path by joining the path tofeaturetools/primitives/datawith the filename supplied by the user.