New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primitive.get_filepath and example of primitive loading data from external files #380
Conversation
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 95.84% 95.85% +0.01%
==========================================
Files 89 89
Lines 7769 7798 +29
==========================================
+ Hits 7446 7475 +29
Misses 323 323
Continue to review full report at Codecov.
|
|
||
def test_get_data_path(es): | ||
class Mod4(TransformPrimitive): | ||
'''Replace each integer with a word from a shakespearean sonnet''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this docstring accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge
This PR adds the method
PrimitiveBase.get_filepath
. This helper function creates an absolute file path by joining the path tofeaturetools/primitives/data
with the filename supplied by the user.