Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pandas version to 0.23 until tests support 0.24 #383

merged 6 commits into from Jan 29, 2019


Copy link

@rwedge rwedge commented Jan 29, 2019

Pandas released version 0.24.0 recently. This PR contains some bugfixes to the tests to make the code more compatible with the new pandas version. The way featuretools implements the LatLong type is incompatible with 0.24 currently (see pandas issue #24986) so until that situation is resolved we're restricting featuretools to pandas 0.23. Pandas 0.24 should work excluding latlongs.

Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #383 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
- Coverage   95.79%   95.75%   -0.04%     
  Files          89       89              
  Lines        7754     7755       +1     
- Hits         7428     7426       -2     
- Misses        326      329       +3
Impacted Files Coverage Δ
featuretools/tests/utils_tests/ 94.28% <100%> (ø) ⬆️
...computational_backends/ 96.98% <100%> (+0.01%) ⬆️
...utational_backend/ 99.3% <100%> (ø) ⬆️
...aturetools/primitives/standard/ 97.79% <0%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb7b29...cd685c3. Read the comment docs.

Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rwedge rwedge merged commit 72ac0da into master Jan 29, 2019
@rwedge rwedge mentioned this pull request Jan 30, 2019
@rwedge rwedge deleted the pin-pandas-23 branch February 19, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants