Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimeSinceFirst, fix TimeSinceLast #388

merged 4 commits into from Jan 31, 2019

Add TimeSinceFirst, fix TimeSinceLast #388

merged 4 commits into from Jan 31, 2019


Copy link

@gsheni gsheni commented Jan 31, 2019

  • Added new primitive TimeSinceFirst
  • Fixed TimeSinceLast
  • Test case for both primitives

@gsheni gsheni changed the title added timesincefirst Add TimeSinceFirst, fix TimeSinceLast Jan 31, 2019
@gsheni gsheni requested a review from kmax12 January 31, 2019 20:33
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #388 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
+ Coverage   95.77%   95.78%   +<.01%     
  Files          90       90              
  Lines        7867     7882      +15     
+ Hits         7535     7550      +15     
  Misses        332      332
Impacted Files Coverage Δ
...ools/primitives/base/ 100% <ø> (ø) ⬆️
...ools/primitives/standard/ 95.75% <100%> (+0.21%) ⬆️
...aturetools/tests/primitive_tests/ 99.19% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f268e62...3b279d1. Read the comment docs.

kmax12 approved these changes Jan 31, 2019
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gsheni gsheni merged commit 75e9ea6 into master Jan 31, 2019
@gsheni gsheni deleted the time_since branch January 31, 2019 20:48
@rwedge rwedge mentioned this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants