Merged
Conversation
Contributor
gsheni
commented
Feb 1, 2019
gsheni
commented
- Fixed list_primitives
- Added test case
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 95.78% 95.97% +0.19%
==========================================
Files 90 91 +1
Lines 7882 7908 +26
==========================================
+ Hits 7550 7590 +40
+ Misses 332 318 -14
Continue to review full report at Codecov.
|
kmax12
reviewed
Feb 1, 2019
| assert x in df['name'].values.tolist() | ||
| for x in ['aggregation', 'transform']: | ||
| assert x in df['type'].values.tolist() | ||
| chars_desc = 'Return the characters in a given string.' |
Contributor
There was a problem hiding this comment.
Get the description text from the primitive object itself.
| chars_desc = 'Return the characters in a given string.' | ||
| day_desc = 'Transform a Datetime feature into the day.' | ||
| last_desc = 'Returns the last value.' | ||
| for x in [chars_desc] + [day_desc] + [last_desc]: |
Contributor
There was a problem hiding this comment.
There could still be an out of order problem. The test should find the row of the primitive and then check the description matches
…into list_primitive_fix
kmax12
approved these changes
Feb 1, 2019
|
|
||
|
|
||
| def test_descriptions(): | ||
| primitives = {NumCharacters: 'Return the characters in a given string.', |
Contributor
There was a problem hiding this comment.
can we add one primitive here that doesn't have a description so we can test the "" case?.
otherwise, it all looks good to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.