-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transform stacking on multi-output aggregation #394
Conversation
gsheni
commented
Feb 1, 2019
- Fixes an assertion issue
- test case to check this.
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
+ Coverage 95.97% 95.98% +<.01%
==========================================
Files 91 91
Lines 7908 7916 +8
==========================================
+ Hits 7590 7598 +8
Misses 318 318
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test case where DFS tries to stack features this way so that we hit the try-catch on codecov?
@rwedge fixed with dfs test that uses a mutli output agg and transform |
…into multi_stack_fix