Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform stacking on multi-output aggregation #394

merged 12 commits into from Feb 2, 2019


Copy link

@gsheni gsheni commented Feb 1, 2019

  • Fixes an assertion issue
  • test case to check this.

@gsheni gsheni self-assigned this Feb 1, 2019
@gsheni gsheni requested a review from rwedge February 1, 2019 19:33
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
+ Coverage   95.97%   95.98%   +<.01%     
  Files          91       91              
  Lines        7908     7916       +8     
+ Hits         7590     7598       +8     
  Misses        318      318
Impacted Files Coverage Δ
featuretools/synthesis/ 94.5% <100%> (+0.01%) ⬆️
featuretools/feature_base/ 96.22% <100%> (ø) ⬆️
...ols/tests/dfs_tests/ 98.33% <100%> (+0.01%) ⬆️
...s/tests/primitive_tests/ 98.05% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22d852...e37dc90. Read the comment docs.

Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test case where DFS tries to stack features this way so that we hit the try-catch on codecov?

Copy link
Member Author

gsheni commented Feb 1, 2019

@rwedge fixed with dfs test that uses a mutli output agg and transform

@gsheni gsheni merged commit 6d991ad into master Feb 2, 2019
@gsheni gsheni deleted the multi_stack_fix branch February 2, 2019 00:27
@rwedge rwedge mentioned this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants