Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that agg_primitives and trans_primitives are right primitive type #397

Merged
merged 4 commits into from
Feb 5, 2019

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Feb 1, 2019

This PR adds a check in DFS to agg_primitives and trans_primitives to give a clearer error when primitives are included in the wrong list (putting Hour in agg_primitives, for exmaple)

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #397 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   95.96%   95.97%   +<.01%     
==========================================
  Files          91       91              
  Lines        7934     7945      +11     
==========================================
+ Hits         7614     7625      +11     
  Misses        320      320
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 94.57% <100%> (+0.06%) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.37% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054da8a...5f6eeec. Read the comment docs.

@rwedge rwedge requested a review from kmax12 February 1, 2019 23:03
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one comment, looks good

@@ -681,3 +681,19 @@ def test_initialized_agg_prim(es):
trans_primitives=[])
features = dfs_obj.build_features()
assert (feature_with_name(features, "N_MOST_COMMON(log.product_id)"))


def test_checks_agg_primitives_are_aggs(es):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method name should be something like test_check_primitives_correct_type

@rwedge rwedge merged commit 56b6f91 into master Feb 5, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
@rwedge rwedge deleted the check-dfs-primitive-inputs branch February 19, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants