Check if graphviz backend is installed #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
- Coverage 95.98% 95.95% -0.03%
==========================================
Files 91 91
Lines 7916 7920 +4
==========================================
+ Hits 7598 7600 +2
- Misses 318 320 +2
Continue to review full report at Codecov.
|
rwedge
suggested changes
Feb 4, 2019
kmax12
reviewed
Feb 4, 2019
|
Looks good. Merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion at the bottom of #381, this PR checks if a working Graphviz backend is installed. If not, it will suggest how to do so like described here.
While #389 added similar hints for the documentation, I'm afraid most people will install the package without reading the docs and then face missing backend issues during runtime.