Skip to content

add comments to feature_tree#400

Merged
kmax12 merged 2 commits intoalteryx:masterfrom
RogerTangos:feature_tree-comments
Feb 4, 2019
Merged

add comments to feature_tree#400
kmax12 merged 2 commits intoalteryx:masterfrom
RogerTangos:feature_tree-comments

Conversation

@RogerTangos
Copy link
Copy Markdown
Contributor

  • describe what some of the instance variables are
  • Add one line break in code, bringing max line size to 100
  • rename all_features in __init__, since it's confusing to have all_features be different from self.all_features

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2019

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          91       91           
  Lines        7916     7916           
=======================================
  Hits         7598     7598           
  Misses        318      318
Impacted Files Coverage Δ
...eaturetools/computational_backends/feature_tree.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9a65c...2de7ab3. Read the comment docs.

@kmax12
Copy link
Copy Markdown
Contributor

kmax12 commented Feb 4, 2019

Looks good! I suspect more work can be done here, but need to start somewhere. Thank you for the contribution. Merging now

@kmax12 kmax12 merged commit c2c6431 into alteryx:master Feb 4, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants