Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configuration object #401

Merged
merged 11 commits into from Feb 5, 2019
Merged

Add new configuration object #401

merged 11 commits into from Feb 5, 2019

Conversation

CharlesBradshaw
Copy link
Contributor

Adds data_path as a static variable and a class method set_data_path to update data_path

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #401 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   95.97%   95.99%   +0.02%     
==========================================
  Files          91       92       +1     
  Lines        7945     7996      +51     
==========================================
+ Hits         7625     7676      +51     
  Misses        320      320
Impacted Files Coverage Δ
featuretools/tests/config_tests/test_config.py 100% <100%> (ø)
featuretools/primitives/base/primitive_base.py 100% <100%> (ø) ⬆️
...retools/tests/primitive_tests/test_feature_base.py 100% <100%> (ø) ⬆️
featuretools/config_init.py 97.82% <100%> (ø)
featuretools/tests/utils_tests/test_config.py 91.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b6f91...ed95747. Read the comment docs.

@kmax12 kmax12 changed the title Add set data path Add new configuration object Feb 5, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ready to merge

@CharlesBradshaw CharlesBradshaw merged commit de2ff0e into master Feb 5, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
@rwedge rwedge deleted the set_data_path branch February 19, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants