Install data and dependencies #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 96.07% 96.11% +0.04%
==========================================
Files 92 92
Lines 8023 8162 +139
==========================================
+ Hits 7708 7845 +137
- Misses 315 317 +2
Continue to review full report at Codecov.
|
kmax12
suggested changes
Feb 8, 2019
| directory = os.path.join(tmp_dir, os.path.dirname(members[0].path)) | ||
| for member in members: | ||
| if os.path.isfile(os.path.join(tmp_dir, member.path)): | ||
| directory = os.path.join(tmp_dir, os.path.dirname(member.path)) |
There was a problem hiding this comment.
should there be a break out of this loop after the directory is found?
featuretools/primitives/install.py
Outdated
| if prompt: | ||
| while True: | ||
| resp = input("Install primitives: %s? (Y/n) " % primitives_list) | ||
| if resp == "Y": |
There was a problem hiding this comment.
should we update this to make it not case sensitive?
| files_to_copy.append(filepath) | ||
| all_primitives.add(primitive_obj.name) | ||
|
|
||
| if all_primitives != set(info['primitives']): |
There was a problem hiding this comment.
just need to add a test for this case
| for filepath in files: | ||
| primitive_name, primitive_obj = load_primitive_from_file(filepath) | ||
| if primitive_obj.name not in info['primitives']: | ||
| raise RuntimeError("Primitive %s not listed in " |
There was a problem hiding this comment.
just need to add a test for this case
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In addition to primitives files,
featuretools installwill now look for a folder named "data" and copy it tofeaturetools/primitives/data/. It will also look for "requirements.txt" and runpip install -r requirements.txtif it finds it.