Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative primitives #410

merged 10 commits into from Feb 11, 2019

Cumulative primitives #410

merged 10 commits into from Feb 11, 2019


Copy link

Fixes #405

Updated cumulative primitives (Count,Sum,Max,Min,Mean) to use new primitive API

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #410 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
+ Coverage   96.14%   96.24%   +0.09%     
  Files          92       93       +1     
  Lines        8232     8434     +202     
+ Hits         7915     8117     +202     
  Misses        317      317
Impacted Files Coverage Δ
featuretools/entityset/ 95.65% <ø> (ø) ⬆️
featuretools/entityset/ 93.84% <ø> (ø) ⬆️ 100% <100%> (ø)
...s/tests/primitive_tests/ 98.51% <100%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b6e04...163ca82. Read the comment docs.

kmax12 approved these changes Feb 7, 2019
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CharlesBradshaw CharlesBradshaw merged commit d93ff0d into master Feb 11, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
@rwedge rwedge deleted the cumulative_primitives branch February 19, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants