Removed Variable dtype #416
Conversation
gsheni
commented
Feb 7, 2019
gsheni
commented
- Variable dtype is unused so we are removing the functionality.
| @@ -44,7 +44,7 @@ def __eq__(self, other): | |||
| self.entity_id == other.entity_id | |||
|
|
|||
| def __repr__(self): | |||
| ret = u"<Variable: {} (dtype = {})>".format(self.name, self.dtype) | |||
| ret = u"<Variable: {} >".format(self.name) | |||
There was a problem hiding this comment.
still print the dtype, just use self._dtype_repr
featuretools/entityset/entity.py
Outdated
| @@ -84,7 +84,7 @@ def __repr__(self): | |||
| repr_out = u"Entity: {}\n".format(self.id) | |||
| repr_out += u" Variables:" | |||
| for v in self.variables: | |||
| repr_out += u"\n {} (dtype: {})".format(v.id, v.dtype) | |||
| repr_out += u"\n {} ".format(v.id) | |||
There was a problem hiding this comment.
still print the dtype, just use self._dtype_repr
| def dtype(self): | ||
| return self._dtype_repr \ | ||
| if self._dtype_repr is not None else "generic_type" | ||
| # @property |
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
- Coverage 96.07% 96.07% -0.01%
==========================================
Files 92 92
Lines 8025 8022 -3
==========================================
- Hits 7710 7707 -3
Misses 315 315
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
- Coverage 96.07% 96.07% -0.01%
==========================================
Files 92 92
Lines 8025 8023 -2
==========================================
- Hits 7710 7708 -2
Misses 315 315
Continue to review full report at Codecov.
|
