Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #419

merged 6 commits into from Feb 8, 2019

Update #419

merged 6 commits into from Feb 8, 2019


Copy link

@gsheni gsheni commented Feb 8, 2019

  • num_words as a primitive is used as one of the dfs default args and in the docs
  • However, the primitive name is numwords so if someone does ft.dfs(trans_primitives='numwords'), it will error
  • Same thing with characters and num_characters
  • Another option is the fix the docstrings
  • This fixes this issue.

@gsheni gsheni self-assigned this Feb 8, 2019
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #419 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
  Coverage   96.11%   96.11%           
  Files          92       92           
  Lines        8162     8162           
  Hits         7845     7845           
  Misses        317      317
Impacted Files Coverage Δ
...retools/primitives/standard/ 100% <100%> (ø) ⬆️
...uretools/tests/utils_tests/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfaca4...b101066. Read the comment docs.

@gsheni gsheni requested a review from rwedge February 8, 2019 16:51
@kmax12 kmax12 merged commit 3ed0692 into master Feb 8, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
@gsheni gsheni deleted the fix_num_words branch February 20, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants