Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive function name uniqueness #424

merged 5 commits into from Feb 8, 2019


Copy link

@rwedge rwedge commented Feb 8, 2019

Fixes some errors related to when multiple primitives used same aggregation function or when two features with same primitive but different parameters were applied to the same base feature.

@kmax12 kmax12 self-requested a review February 8, 2019 21:34
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #424 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
+ Coverage   96.11%   96.14%   +0.03%     
  Files          92       92              
  Lines        8162     8232      +70     
+ Hits         7845     7915      +70     
  Misses        317      317
Impacted Files Coverage Δ
...turetools/computational_backends/ 98.2% <100%> (+0.01%) ⬆️
...tests/computational_backend/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed0692...30bc9bf. Read the comment docs.

Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@rwedge rwedge merged commit 659ebf4 into master Feb 8, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
@rwedge rwedge deleted the primitive-function-name-uniqueness branch February 19, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants