added ips and email address to mock ds #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gsheni
commented
Feb 11, 2019
gsheni
commented
- Added new Variable Type, IP Address and email address
- Added these types to mock_ds
- Added to docs
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 96.24% 96.24% +<.01%
==========================================
Files 93 93
Lines 8433 8440 +7
==========================================
+ Hits 8116 8123 +7
Misses 317 317
Continue to review full report at Codecov.
|
kmax12
suggested changes
Feb 11, 2019
|
Thematically, wouldn't IP address make more sense as as session variable and email as a customer variable? |
Fixed. |
gsheni
commented
Feb 12, 2019
| @@ -75,10 +75,10 @@ def test_update_data(es): | |||
| es['customers'].update_data(df.drop(columns=['cohort'])) | |||
| assert 'Updated dataframe is missing new cohort column' in str(excinfo) | |||
|
|
|||
| error_text = 'Updated dataframe contains 13 columns, expecting 12' | |||
| error_text = 'Updated dataframe contains 14 columns, expecting 13' | |||
There was a problem hiding this comment.
1 more column(email) was added to the customer's entity.
gsheni
commented
Feb 12, 2019
| with pytest.raises(ValueError, match=error_text) as excinfo: | ||
| es['customers'].update_data(df) | ||
| assert 'Updated dataframe contains 13 columns, expecting 12' in str(excinfo) | ||
| assert 'Updated dataframe contains 14 columns, expecting 13' in str(excinfo) |
There was a problem hiding this comment.
1 more column(ip) was added to the session's entity.
kmax12
approved these changes
Feb 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.