Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity.query_by_values now preserves row order of underlying data #428

merged 9 commits into from Feb 12, 2019


Copy link

Previously the query by values didn't guarantee that the rows would be returned in the order of the original dataframe. This caused issues for cumulative primitives.

@kmax12 kmax12 changed the title Entity Query by Values Now Returns Rows In Order Entity.query_by_values now preserves row order of underlying data Feb 12, 2019
kmax12 approved these changes Feb 12, 2019
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once tests pass

Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #428 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
+ Coverage   96.24%   96.24%   +<.01%     
  Files          93       93              
  Lines        8440     8447       +7     
+ Hits         8123     8130       +7     
  Misses        317      317
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/ 100% <100%> (ø) ⬆️
featuretools/entityset/ 95.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a92950...b4e314e. Read the comment docs.

@CharlesBradshaw CharlesBradshaw merged commit d24b64d into master Feb 12, 2019
@CharlesBradshaw CharlesBradshaw deleted the entity_shuffle_fix branch February 12, 2019 21:15
@rwedge rwedge mentioned this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants