Entity.query_by_values now preserves row order of underlying data #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmax12
changed the title
kmax12
approved these changes
Feb 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 96.24% 96.24% +<.01%
==========================================
Files 93 93
Lines 8440 8447 +7
==========================================
+ Hits 8123 8130 +7
Misses 317 317
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the query by values didn't guarantee that the rows would be returned in the order of the original dataframe. This caused issues for cumulative primitives.