-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Country Code and Sub Region Codes as variable types #430
Conversation
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
+ Coverage 96.24% 96.25% +<.01%
==========================================
Files 93 93
Lines 8447 8455 +8
==========================================
+ Hits 8130 8138 +8
Misses 317 317
Continue to review full report at Codecov.
|
Will add tests and docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. Ready to merge after my two comments are addressed. Thank you for the contribution!
changed _dtype_repr to include underscore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you very much for the contribution.
No description provided.