Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Country Code and Sub Region Codes as variable types #430

Merged
merged 10 commits into from
Feb 14, 2019

Conversation

jxwolstenholme
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #430 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   96.24%   96.25%   +<.01%     
==========================================
  Files          93       93              
  Lines        8447     8455       +8     
==========================================
+ Hits         8130     8138       +8     
  Misses        317      317
Impacted Files Coverage Δ
featuretools/tests/testing_utils/mock_ds.py 87.76% <100%> (+0.17%) ⬆️
featuretools/variable_types/variable.py 97.29% <100%> (+0.15%) ⬆️
featuretools/entityset/entity.py 95.65% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f69e70...0b08f33. Read the comment docs.

@jxwolstenholme
Copy link
Contributor Author

Will add tests and docs

Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Ready to merge after my two comments are addressed. Thank you for the contribution!

featuretools/variable_types/variable.py Outdated Show resolved Hide resolved
featuretools/variable_types/variable.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much for the contribution.

@kmax12 kmax12 merged commit 1998ec7 into alteryx:master Feb 14, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants