Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace NUnique get_function #434

merged 5 commits into from Feb 15, 2019


Copy link

@rwedge rwedge commented Feb 14, 2019

No description provided.

Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #434 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
- Coverage   96.33%   96.29%   -0.04%     
  Files          93       93              
  Lines        8450     8455       +5     
+ Hits         8140     8142       +2     
- Misses        310      313       +3
Impacted Files Coverage Δ
...ools/primitives/standard/ 94.66% <50%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2e649...790c9fa. Read the comment docs.

Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link

kmax12 commented Feb 15, 2019

Actually, looks let's test are failing in 2.7. might have to use a different function

@kmax12 kmax12 merged commit 15b7dae into master Feb 15, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
@rwedge rwedge deleted the change-nunique-backend-function branch February 19, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants