Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haversine Unit argument #435

Merged
merged 7 commits into from
Feb 20, 2019
Merged

Haversine Unit argument #435

merged 7 commits into from
Feb 20, 2019

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Feb 14, 2019

  • Added a unit argument to the Haversine primitive to specify miles or kilometers
  • Added a test case which checks this calculation.

@gsheni gsheni self-assigned this Feb 14, 2019
@gsheni gsheni requested a review from kmax12 February 14, 2019 22:39
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #435 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   96.32%   96.33%   +0.01%     
==========================================
  Files          95       95              
  Lines        8514     8539      +25     
==========================================
+ Hits         8201     8226      +25     
  Misses        313      313
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.53% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd2108...ff0e143. Read the comment docs.

@gsheni gsheni merged commit 2d31ebb into master Feb 20, 2019
@gsheni gsheni deleted the haversine_unit branch February 20, 2019 20:53
@rwedge rwedge mentioned this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants