-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhoneNumber, DateOfBirth, URL variable types #447
Conversation
0d4ec8f
to
8da483f
Compare
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
+ Coverage 96.45% 96.46% +<.01%
==========================================
Files 98 98
Lines 8611 8620 +9
==========================================
+ Hits 8306 8315 +9
Misses 305 305
Continue to review full report at Codecov.
|
'engagement_level': [1, 3, 2], | ||
'email': ['john.smith@example.com', '', np.nan], | ||
'url': ['google.com', 'https://www.featuretools.com/', np.nan], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL is property better to put in the products
dataframe.
@@ -257,6 +257,24 @@ class EmailAddress(Variable): | |||
_default_pandas_dtype = str | |||
|
|||
|
|||
class URL(Variable): | |||
"""Represents a valid web url""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put more information in this docstring. Saying that having a url with/without http
and www
is okay.
|
||
|
||
class PhoneNumber(Variable): | ||
"""Represents a valid phone number""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put more information in this docstring. Saying that having a phone number with/without area and country code is okay, as well as a phone number with parentheses.
@gsheni addressed your comments! if this looks good, I can squash and re-push, which I think will take care of the CLA issue |
@glentennis you need to agree to the Contributor License Agreement, please follow these steps Or try click this link |
8d1a410
to
01cb2ed
Compare
Hey @gsheni, looks like we're good to go on this! |
c9e3d64
to
058a3e1
Compare
@glentennis fyi |
thanks! totally missed that |
6ff2c8d
to
40dd429
Compare
@gsheni checks passed, can you merge this? |
closes #443
@gsheni wanna take a look? I wasn't exactly sure if I was supposed to make changes to
featuretools/tests/entityset_tests/test_entity.py
, but I took a stab at it anyway.Also made a couple changes to unrelated files via
make lint-fix