Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test featuretools on CI using packaged source files #459

merged 26 commits into from Mar 15, 2019


Copy link

@rwedge rwedge commented Mar 11, 2019

Fixes #442

Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #459 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
+ Coverage   96.48%   96.49%   +<.01%     
  Files          99      102       +3     
  Lines        8675     8693      +18     
+ Hits         8370     8388      +18     
  Misses        305      305
Impacted Files Coverage Δ
featuretools/selection/ 100% <0%> (ø)
featuretools/wrappers/ 100% <0%> (ø)
featuretools/ 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86b6d8...e9e2625. Read the comment docs.

FEATURETOOLS_VERSION=$(python --version)
pip install -e "featuretools-${FEATURETOOLS_VERSION}/"
pip install -r "featuretools-${FEATURETOOLS_VERSION}/test-requirements.txt"
pip install -r dev-requirements.txt
Copy link

@gsheni gsheni Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev requirements installs test-requirements.
So it seems like the test-requirements install is redundant.

.circleci/config.yml Outdated Show resolved Hide resolved
@kmax12 kmax12 self-requested a review March 14, 2019 18:40
@rwedge rwedge changed the title [WIP] Test featuretools on CI using packaged source files Test featuretools on CI using packaged source files Mar 15, 2019
@rwedge rwedge merged commit 6feaf93 into master Mar 15, 2019
@rwedge rwedge deleted the test-ci-with-packaged-featuretools branch March 15, 2019 15:38
@rwedge rwedge mentioned this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants