-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test featuretools on CI using packaged source files #459
Conversation
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 96.48% 96.49% +<.01%
==========================================
Files 99 102 +3
Lines 8675 8693 +18
==========================================
+ Hits 8370 8388 +18
Misses 305 305
Continue to review full report at Codecov.
|
.circleci/config.yml
Outdated
FEATURETOOLS_VERSION=$(python setup.py --version) | ||
pip install -e "featuretools-${FEATURETOOLS_VERSION}/" | ||
pip install -r "featuretools-${FEATURETOOLS_VERSION}/test-requirements.txt" | ||
pip install -r dev-requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev requirements installs test-requirements.
So it seems like the test-requirements install is redundant.
https://github.com/Featuretools/featuretools/blob/master/dev-requirements.txt#L1
…retools/featuretools into test-ci-with-packaged-featuretools
Fixes #442