Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #468

merged 2 commits into from Mar 20, 2019

Update #468

merged 2 commits into from Mar 20, 2019


Copy link

@gsheni gsheni commented Mar 20, 2019

  • We make a variable called method in the primitive base. However, this should be named _method so that it does not conflict with any primitive parameters.

@gsheni gsheni self-assigned this Mar 20, 2019
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
  Coverage   96.24%   96.24%           
  Files         102      102           
  Lines        8724     8724           
  Hits         8396     8396           
  Misses        328      328
Impacted Files Coverage Δ
featuretools/primitives/base/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6a947...ae60e62. Read the comment docs.

Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@gsheni gsheni merged commit 9f4858f into master Mar 20, 2019
@gsheni gsheni deleted the rename_base_attribute branch March 20, 2019 19:19
@rwedge rwedge mentioned this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants