Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby dfs #472

Merged
merged 57 commits into from
Mar 28, 2019
Merged

Groupby dfs #472

merged 57 commits into from
Mar 28, 2019

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Mar 22, 2019

Building off of #455, adds groupby parameter to DeepFeatureSynthesis and ft.dfs

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #472 into master will increase coverage by 0.01%.
The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #472      +/-   ##
=========================================
+ Coverage   96.29%   96.3%   +0.01%     
=========================================
  Files         103     103              
  Lines        8849    8882      +33     
=========================================
+ Hits         8521    8554      +33     
  Misses        328     328
Impacted Files Coverage Δ
featuretools/tests/dfs_tests/test_dfs_method.py 98.41% <ø> (ø) ⬆️
featuretools/synthesis/dfs.py 73.91% <ø> (ø) ⬆️
featuretools/feature_base/feature_base.py 96.46% <100%> (ø) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.55% <100%> (+0.05%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 96.75% <96.55%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f308195...a0ec863. Read the comment docs.

@rwedge rwedge changed the base branch from grouby-transform-feature to master March 25, 2019 16:48
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good. Just a few minor comments then it should be good to merge

docs/source/changelog.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwedge rwedge merged commit da19f29 into master Mar 28, 2019
@rwedge rwedge deleted the groupby-dfs branch March 28, 2019 19:08
@rwedge rwedge mentioned this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants