-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groupby dfs #472
Groupby dfs #472
Conversation
…ng all base features
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=========================================
+ Coverage 96.29% 96.3% +0.01%
=========================================
Files 103 103
Lines 8849 8882 +33
=========================================
+ Hits 8521 8554 +33
Misses 328 328
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good. Just a few minor comments then it should be good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Building off of #455, adds
groupby
parameter to DeepFeatureSynthesis andft.dfs