Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for duplicates Fix #479

merged 11 commits into from Apr 9, 2019

Check for duplicates Fix #479

merged 11 commits into from Apr 9, 2019


Copy link

@minkvsky minkvsky commented Apr 5, 2019

Fixes #467
I found the problem is caused while generating child_columns in es.get_pandas_data_slice;
I think a suitable solution is to adjust the vtypes of variable in relationship; On the other hand, now that we could change and in special case, we also standardize them as vtypes.Id or vtypes.Index

Copy link

CLAassistant commented Apr 5, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #479 into master will decrease coverage by 0.02%.
The diff coverage is 96.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
- Coverage   96.25%   96.23%   -0.03%     
  Files         102      104       +2     
  Lines        8607     8658      +51     
+ Hits         8285     8332      +47     
- Misses        322      326       +4
Impacted Files Coverage Δ
featuretools/tests/testing_utils/ 87.85% <ø> (ø) ⬆️
...retools/primitives/standard/ 100% <ø> (ø) ⬆️
...etools/primitives/base/ 100% <100%> (ø) ⬆️
featuretools/entityset/ 95.04% <100%> (ø) ⬆️
...ools/primitives/base/ 100% <100%> (ø) ⬆️
.../tests/primitive_tests/ 100% <100%> (ø)
...ests/primitive_tests/ 84.61% <84.61%> (ø)
...computational_backends/ 96.98% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf98910...edcf04e. Read the comment docs.

@gsheni gsheni changed the title Bugfix issue 467 Check for duplicates Fix Apr 5, 2019
Copy link

kmax12 commented Apr 5, 2019

hi @minkvsky this looks great. thank you for tracking it down.

before we can merge, can you add a test case to make sure the variable type conversion during add relationships happens correctly?

@kmax12 kmax12 self-requested a review April 8, 2019 17:25
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants