-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for duplicates Fix #479
Conversation
…ools/featuretools into update_make_primitives2
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 96.25% 96.23% -0.03%
==========================================
Files 102 104 +2
Lines 8607 8658 +51
==========================================
+ Hits 8285 8332 +47
- Misses 322 326 +4
Continue to review full report at Codecov.
|
hi @minkvsky this looks great. thank you for tracking it down. before we can merge, can you add a test case to make sure the variable type conversion during add relationships happens correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
Fixes #467
I found the problem is caused while generating child_columns in es.get_pandas_data_slice;
I think a suitable solution is to adjust the vtypes of variable in relationship; On the other hand, now that we could change
relationship.child_variable.id
andrelationship.parent_variable.id
(es.add_relationship) in special case, we also standardize them asvtypes.Id
orvtypes.Index