Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AggregationPrimitive docstring updates #489

Merged
merged 39 commits into from
Apr 19, 2019
Merged

AggregationPrimitive docstring updates #489

merged 39 commits into from
Apr 19, 2019

Conversation

glentennis
Copy link
Contributor

@glentennis glentennis commented Apr 11, 2019 •
edited
Loading

Updating AggregationPrimitive docstrings to a new format with a longer description and doctests.

@glentennis glentennis changed the title AggregationPrimitive doctest updates AggregationPrimitive docstring updates Apr 11, 2019
@codecov
Copy link

codecov bot commented Apr 11, 2019 •
edited
Loading

Codecov Report

Merging #489 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   96.09%   96.08%   -0.02%     
==========================================
  Files         108      108              
  Lines        8862     8864       +2     
==========================================
+ Hits         8516     8517       +1     
- Misses        346      347       +1
Impacted Files Coverage Δ
...uretools/tests/utils_tests/test_list_primitives.py 100% <ø> (ø) ⬆️
...retools/primitives/standard/transform_primitive.py 100% <ø> (ø) ⬆️
...ools/primitives/standard/aggregation_primitives.py 94.49% <66.66%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14939d1...f1b3553. Read the comment docs.

@glentennis glentennis force-pushed the AggregationPrimitive-doctests branch 2 times, most recently from 5e3b918 to b044fb8 Compare April 11, 2019 20:55
@glentennis glentennis force-pushed the AggregationPrimitive-doctests branch from f733dd7 to 926f7a0 Compare April 11, 2019 21:11
@gsheni
Copy link
Contributor

gsheni commented Apr 12, 2019

@glentennis can you fix the conflict?

@gsheni gsheni requested review from gsheni and kmax12 April 12, 2019 19:23
kmax12
kmax12 suggested changes Apr 16, 2019
View reviewed changes
kmax12
kmax12 suggested changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comment. Looking almost ready to merge

@gsheni
Copy link
Contributor

gsheni commented Apr 18, 2019

Will merge in once #499 gets merged into master

kmax12
kmax12 approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni merged commit dd2a8e3 into alteryx:master Apr 19, 2019
@rwedge rwedge mentioned this pull request Apr 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni approved these changes

@kmax12 kmax12 kmax12 approved these changes

Assignees

@glentennis glentennis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glentennis @gsheni @kmax12