BinaryTransform docstrings #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 108 108
Lines 8864 8864
=======================================
Hits 8517 8517
Misses 347 347
Continue to review full report at Codecov.
|
kmax12
suggested changes
Apr 16, 2019
| @@ -15,6 +15,18 @@ | |||
|
|
|||
|
|
|||
| class GreaterThan(TransformPrimitive): | |||
| """Determines if values X are greater than values Y. | |||
There was a problem hiding this comment.
what are X and Y? this should be "Determines if values in one list are greater than another list". fine to keep x and y in extended description below though
let's apply this rule to all the primitives below too
glentennis
force-pushed
the
Binary-doctrings
branch
from
7d07989
to
89283d8
Compare
glentennis
force-pushed
the
Binary-doctrings
branch
from
81a81d0
to
9719382
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding docstrings to BinaryTransform primitives, with a full description, args, and doctests.