Remove primitives that return strings instead of functions #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
- Coverage 96.1% 96.09% -0.01%
==========================================
Files 108 108
Lines 8853 8862 +9
==========================================
+ Hits 8508 8516 +8
- Misses 345 346 +1
Continue to review full report at Codecov.
|
kmax12
commented
Apr 17, 2019
| @@ -26,7 +26,7 @@ class Count(AggregationPrimitive): | |||
| default_value = 0 | |||
|
|
|||
| def get_function(self): | |||
| return 'count' | |||
| return pd.Series.count | |||
There was a problem hiding this comment.
this actually isn't as performant. added question on stackoverflow here: https://stackoverflow.com/questions/55731149/use-a-function-instead-of-string-in-pandas-groupby-agg
kmax12
commented
Apr 17, 2019
| @@ -261,7 +261,7 @@ class Skew(AggregationPrimitive): | |||
| stack_on_self = False | |||
|
|
|||
| def get_function(self): | |||
| return 'skew' | |||
| return pd.Series.skew | |||
There was a problem hiding this comment.
skew doesn't seem to matter as much as count
kmax12
force-pushed
the
update-string-primitives
branch
from
cbe1eb0
to
8a7b3fd
Compare
rwedge
reviewed
Apr 17, 2019
rwedge
reviewed
Apr 17, 2019
rwedge
reviewed
Apr 17, 2019
|
Looks good |
rwedge
approved these changes
Apr 18, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We were returning strings in some cases to improve performance. This breaks api with other primitives. We can simply return pandas objects instead add the string optimization into pandas backend.