Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing type casting in Equals and NotEquals Primitives #504

Merged
merged 9 commits into from
Dec 19, 2019

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Apr 17, 2019

We were doing the casting to be careful, but there is no need because pandas will handle it internally

This should fix #500 and #496

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #504 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
- Coverage   97.63%   97.63%   -0.01%     
==========================================
  Files         118      118              
  Lines       10201    10177      -24     
==========================================
- Hits         9960     9936      -24     
  Misses        241      241
Impacted Files Coverage Δ
...aturetools/primitives/standard/binary_transform.py 100% <100%> (ø) ⬆️
featuretools/utils/wrangle.py 74.71% <0%> (-0.85%) ⬇️
featuretools/entityset/deserialize.py 98.94% <0%> (-0.11%) ⬇️
...etools/tests/entityset_tests/test_serialization.py 97.92% <0%> (-0.07%) ⬇️
featuretools/entityset/serialize.py 98.73% <0%> (-0.02%) ⬇️
featuretools/tests/entityset_tests/test_entity.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd1df0...5b7418c. Read the comment docs.

@kmax12
Copy link
Contributor Author

kmax12 commented Aug 26, 2019

@tlyleung
Copy link

This PR fixes the problem! The ValueError: Cannot convert non-finite values (NA or inf) to integer error no longer occurs and the features are built without a hitch.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2019

CLA assistant check
All committers have signed the CLA.

@apemann
Copy link

apemann commented Dec 12, 2019

Can this fix make it into the next release please? It looks like it's almost done.

@codecov-io
Copy link

Codecov Report

Merging #504 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files         117      117           
  Lines       10851    10851           
=======================================
  Hits        10651    10651           
  Misses        200      200
Impacted Files Coverage Δ
...aturetools/primitives/standard/binary_transform.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48dbae...9901cb3. Read the comment docs.

@kmax12 kmax12 merged commit 90b67ff into master Dec 19, 2019
@apemann
Copy link

apemann commented Dec 19, 2019

Thank you @rwedge and @kmax12!

@rwedge rwedge deleted the remove-casting branch December 20, 2019 00:16
@rwedge rwedge mentioned this pull request Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading previously saved features: ValueError: cannot convert float NaN to integer
6 participants