-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing type casting in Equals and NotEquals Primitives #504
Conversation
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
- Coverage 97.63% 97.63% -0.01%
==========================================
Files 118 118
Lines 10201 10177 -24
==========================================
- Hits 9960 9936 -24
Misses 241 241
Continue to review full report at Codecov.
|
This is appears to be the problem here: https://stackoverflow.com/questions/57601595/how-to-write-seed-features-that-work-with-cutoff-time?noredirect=1#comment101752737_57601595 |
This PR fixes the problem! The |
Can this fix make it into the next release please? It looks like it's almost done. |
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 117 117
Lines 10851 10851
=======================================
Hits 10651 10651
Misses 200 200
Continue to review full report at Codecov.
|
We were doing the casting to be careful, but there is no need because pandas will handle it internally
This should fix #500 and #496