Skip to content

Updated Primitive Call Tests and NMostCommon Implementation #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 26, 2019
Merged

Updated Primitive Call Tests and NMostCommon Implementation #516

merged 7 commits into from
Apr 26, 2019

Conversation

CharlesBradshaw
Copy link
Contributor

@CharlesBradshaw CharlesBradshaw commented Apr 26, 2019 •
edited
Loading

Fixes #463

@CharlesBradshaw CharlesBradshaw changed the title Updated Tests Updated Primitive Call Tests and NMostCommon Implementation Apr 26, 2019
@codecov
Copy link

codecov bot commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #516 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   96.09%   96.09%   -0.01%     
==========================================
  Files         108      108              
  Lines        8893     8881      -12     
==========================================
- Hits         8546     8534      -12     
  Misses        347      347
Impacted Files Coverage Δ
...ools/primitives/standard/aggregation_primitives.py 94.49% <100%> (ø) ⬆️
...tools/tests/primitive_tests/test_primitive_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b528079...f4c740a. Read the comment docs.

@CharlesBradshaw CharlesBradshaw requested a review from rwedge April 26, 2019 17:56
rwedge
rwedge approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@CharlesBradshaw CharlesBradshaw merged commit 00b7e9e into master Apr 26, 2019
@CharlesBradshaw CharlesBradshaw deleted the primitive_call_update branch April 26, 2019 19:28
@rwedge rwedge mentioned this pull request May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Primitive Call Tests
2 participants
@CharlesBradshaw @rwedge