Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile #519

Merged
merged 1 commit into from Apr 29, 2019
Merged

Update Makefile #519

merged 1 commit into from Apr 29, 2019

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Apr 29, 2019

  • Add .PHONY target to makefile

@gsheni gsheni requested a review from rwedge April 29, 2019 16:02
@gsheni gsheni self-assigned this Apr 29, 2019
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #519 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #519   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         108      108           
  Lines        8881     8881           
=======================================
  Hits         8534     8534           
  Misses        347      347

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b7e9e...854b630. Read the comment docs.

rwedge
rwedge approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 37175e2 into master Apr 29, 2019
@gsheni gsheni deleted the add_phony_makefile branch April 29, 2019 16:11
@rwedge rwedge mentioned this pull request May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsheni @rwedge