Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when target entity does not exist #520

merged 2 commits into from Apr 29, 2019


Copy link

Also improve error message for EntitySets without an id when there is no
entity with the given name.

Resolves #466.

Copy link

CLAassistant commented Apr 29, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #520 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #520      +/-   ##
+ Coverage   96.09%   96.1%   +<.01%     
  Files         108     108              
  Lines        8881    8898      +17     
+ Hits         8534    8551      +17     
  Misses        347     347
Impacted Files Coverage Δ
featuretools/synthesis/ 96.77% <100%> (+0.03%) ⬆️
...uretools/tests/entityset_tests/ 96.9% <100%> (+0.13%) ⬆️
featuretools/entityset/ 95.05% <100%> (+0.01%) ⬆️
...ols/tests/dfs_tests/ 98.58% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759a3c9...467f137. Read the comment docs.

Also improve error message for EntitySets without an id when there is no
entity with the given name.
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CJStadler CJStadler merged commit 269307e into master Apr 29, 2019
@CJStadler CJStadler deleted the missing-target-entity branch April 29, 2019 21:25
@rwedge rwedge mentioned this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Improve error message when target entity doesn't exist in your entityset
3 participants