Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameter in Entity._handle_time #524

Merged
merged 2 commits into from Apr 30, 2019
Merged

Remove unused parameter in Entity._handle_time #524

merged 2 commits into from Apr 30, 2019

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Apr 30, 2019

columns isn't used by the function so this PR removes it

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #524 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #524   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files         108     108           
  Lines        8913    8913           
======================================
  Hits         8566    8566           
  Misses        347     347
Impacted Files Coverage Δ
featuretools/entityset/entity.py 96.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2feb3f...518c42c. Read the comment docs.

@rwedge rwedge requested a review from kmax12 April 30, 2019 20:06
@rwedge rwedge changed the title Unused param in entity handle time Remove unused paramter in Entity._handle_time Apr 30, 2019
@rwedge rwedge changed the title Remove unused paramter in Entity._handle_time Remove unused parameter in Entity._handle_time Apr 30, 2019
kmax12
kmax12 approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwedge rwedge merged commit 0b05842 into master Apr 30, 2019
@rwedge rwedge deleted the unused-param-in-entity-handle-time branch April 30, 2019 20:52
@rwedge rwedge mentioned this pull request May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmax12 kmax12 kmax12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rwedge @kmax12