Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

featuretools_primitives entry point expects list of primitive classes #529

Merged
merged 4 commits into from May 3, 2019
Merged

featuretools_primitives entry point expects list of primitive classes #529

merged 4 commits into from May 3, 2019

Conversation

rwedge
Copy link
Collaborator

@rwedge rwedge commented May 3, 2019

No description provided.

@codecov
Copy link

codecov bot commented May 3, 2019 •
edited

Codecov Report

Merging #529 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #529   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files         108     108           
  Lines        8915    8915           
======================================
  Hits         8568    8568           
  Misses        347     347
Impacted Files Coverage Δ
featuretools/primitives/__init__.py 30% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1e47a...93055d8. Read the comment docs.

@rwedge rwedge changed the title featuretools_primitives entry point expects list of primitive classes [WIP] featuretools_primitives entry point expects list of primitive classes May 3, 2019
@kmax12 kmax12 self-requested a review May 3, 2019 20:05
@kmax12 kmax12 changed the title [WIP] featuretools_primitives entry point expects list of primitive classes featuretools_primitives entry point expects list of primitive classes May 3, 2019
kmax12
kmax12 approved these changes May 3, 2019
View changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmax12 kmax12 merged commit 0739b88 into master May 3, 2019
@rwedge rwedge mentioned this pull request May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmax12 kmax12 kmax12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rwedge @kmax12