Improve duplicate features check in DFS#538
Merged
Conversation
The previous version becomes very slow as the number of features increases. Because it looked up the count for every element its run time was quadratic. The implementation in this commit should be linear.
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
- Coverage 96.26% 96.26% -0.01%
==========================================
Files 114 114
Lines 9258 9256 -2
==========================================
- Hits 8912 8910 -2
Misses 346 346
Continue to review full report at Codecov.
|
Contributor
|
Logic seems good.
@kmax12 thoughts? Does the hash check in |
Contributor
|
@rwedge i believe you're right. looks like |
rwedge
previously approved these changes
May 10, 2019
For possible compatibility issues
…aturetools into duplicate-features-check
rwedge
approved these changes
May 10, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version becomes very slow as the number of features
increases. Because it looked up the count for every element its run time
was quadratic. The implementation in this commit should be linear.
Is this check even necessary though?