Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra requirements #551

merged 9 commits into from May 21, 2019

add extra requirements #551

merged 9 commits into from May 21, 2019


Copy link

@gsheni gsheni commented May 20, 2019

  • Add extra requirements for featuretools plugins

@gsheni gsheni self-assigned this May 20, 2019
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #551   +/-   ##
  Coverage   96.31%   96.31%           
  Files         115      115           
  Lines        9167     9167           
  Hits         8829     8829           
  Misses        338      338

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51cdf87...6f8e32e. Read the comment docs.

@gsheni gsheni requested review from kmax12 and rwedge May 20, 2019 21:37
Copy link

rwedge commented May 21, 2019

Should we test installing these extras as part of our CI tests?

Copy link
Member Author

gsheni commented May 21, 2019

@rwedge PR now tests importing the extra packages.

rwedge previously requested changes May 21, 2019
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
kmax12 approved these changes May 21, 2019
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@kmax12 kmax12 merged commit 6cdf010 into master May 21, 2019
@kmax12 kmax12 deleted the add_extra_reqs branch May 21, 2019 21:10
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants