Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding unit paramater to timesince primitives (issue 503) #558

Merged
merged 9 commits into from May 22, 2019
Merged

Conversation

ctduffy
Copy link
Contributor

@ctduffy ctduffy commented May 22, 2019

fixes #503

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #558 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   96.31%   96.33%   +0.02%     
==========================================
  Files         115      116       +1     
  Lines        9167     9221      +54     
==========================================
+ Hits         8829     8883      +54     
  Misses        338      338
Impacted Files Coverage Δ
featuretools/utils/time_utils.py 95.65% <100%> (+1.2%) ⬆️
featuretools/tests/utils_tests/test_time_utils.py 95.55% <100%> (+1.26%) ⬆️
featuretools/utils/api.py 100% <100%> (ø) ⬆️
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️
.../tests/primitive_tests/test_transform_primitive.py 100% <100%> (ø)
...ools/primitives/standard/aggregation_primitives.py 94.58% <100%> (+0.09%) ⬆️
...tools/tests/primitive_tests/test_primitive_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdf010...13f3a3f. Read the comment docs.

@ctduffy ctduffy requested a review from rwedge May 22, 2019 16:31
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add an args section and an example to the TimeSinceFirst docstring

featuretools/primitives/standard/transform_primitive.py Outdated Show resolved Hide resolved
featuretools/tests/utils_tests/test_time_utils.py Outdated Show resolved Hide resolved
featuretools/utils/time_utils.py Outdated Show resolved Hide resolved
featuretools/primitives/standard/aggregation_primitives.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ctduffy ctduffy merged commit 7dc7d02 into master May 22, 2019
@ctduffy ctduffy deleted the issue503 branch May 22, 2019 22:13
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeSince primitives should optionally take a unit parameter
2 participants