-
Notifications
You must be signed in to change notification settings - Fork 902
test calculating features with instances that aren't in data #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 96.31% 96.33% +0.02%
==========================================
Files 115 115
Lines 9167 9207 +40
==========================================
+ Hits 8829 8870 +41
+ Misses 338 337 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 96.33% 96.36% +0.02%
==========================================
Files 116 116
Lines 9221 9262 +41
==========================================
+ Hits 8883 8925 +42
+ Misses 338 337 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @rwedge! One optional suggestion.
|
||
|
||
def test_instances_not_in_data(es): | ||
instances = list(range(20, 30)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure that these are not in the data (and make it explicit to the reader) you could do something like take the max of the actual ids and then pick 10 higher numbers.
This PR adds some tests for the output of
calculate_feature_matrix
when some of the instances to calculate for aren't in the EntitySet's data