Skip to content

test calculating features with instances that aren't in data #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2019

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented May 22, 2019

This PR adds some tests for the output of calculate_feature_matrix when some of the instances to calculate for aren't in the EntitySet's data

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #559 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   96.31%   96.33%   +0.02%     
==========================================
  Files         115      115              
  Lines        9167     9207      +40     
==========================================
+ Hits         8829     8870      +41     
+ Misses        338      337       -1
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 99.35% <100%> (+0.04%) ⬆️
...computational_backends/calculate_feature_matrix.py 98.33% <0%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdf010...5d3d302. Read the comment docs.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #559 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   96.33%   96.36%   +0.02%     
==========================================
  Files         116      116              
  Lines        9221     9262      +41     
==========================================
+ Hits         8883     8925      +42     
+ Misses        338      337       -1
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 99.35% <100%> (+0.04%) ⬆️
...computational_backends/calculate_feature_matrix.py 98.33% <0%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc7d02...28cced3. Read the comment docs.

@rwedge rwedge requested a review from CJStadler May 22, 2019 20:27
CJStadler
CJStadler previously approved these changes May 22, 2019
Copy link
Contributor

@CJStadler CJStadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rwedge! One optional suggestion.



def test_instances_not_in_data(es):
instances = list(range(20, 30))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure that these are not in the data (and make it explicit to the reader) you could do something like take the max of the actual ids and then pick 10 higher numbers.

@rwedge rwedge merged commit c139527 into master May 22, 2019
@rwedge rwedge deleted the test-missing-rows branch May 22, 2019 22:26
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants