Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load and save functionality for open files and strings #566

Merged
merged 12 commits into from May 30, 2019

Conversation

allisonportis
Copy link
Contributor

@allisonportis allisonportis commented May 28, 2019

fixes #73

Updated /featuretools/feature_base save and load to fulfill:

Returns the serialized features as a string
ft.save_features(features)

Saves the serialized features as a file
ft.save_features(features, '/path/to/save/to.txt')

Save the features to open file f
ft.save_features(features, f)

Loads features from string:
ft.load_features(feature_str)

Loads features from file path:
ft.load_features('/path/to/features')

Loads features from open file f:
ft.load_features(f)

@CLAassistant
Copy link

CLAassistant commented May 28, 2019

CLA assistant check
All committers have signed the CLA.

@allisonportis allisonportis changed the title fixes #73: load and save functionality for open files and strings load and save functionality for open files and strings May 28, 2019
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #566 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   96.43%   96.47%   +0.03%     
==========================================
  Files         117      117              
  Lines        9505     9524      +19     
==========================================
+ Hits         9166     9188      +22     
+ Misses        339      336       -3
Impacted Files Coverage Δ
featuretools/feature_base/features_serializer.py 100% <100%> (ø) ⬆️
featuretools/feature_base/features_deserializer.py 98.24% <100%> (+0.16%) ⬆️
...ests/primitive_tests/test_feature_serialization.py 100% <100%> (ø) ⬆️
...etools/tests/entityset_tests/test_serialization.py 100% <0%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec567c2...2a74805. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@allisonportis allisonportis merged commit d4f5d5f into master May 30, 2019
@rwedge rwedge mentioned this pull request Jun 19, 2019
@rwedge rwedge deleted the load_and_save branch February 19, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading / saving features doesn't support file-like objects as input
3 participants