Fixed testing issue with residual directories causing FileExistsError for makedirs() #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
- Coverage 96.46% 96.43% -0.04%
==========================================
Files 117 117
Lines 9511 9505 -6
==========================================
- Hits 9175 9166 -9
- Misses 336 339 +3
Continue to review full report at Codecov.
|
rwedge
reviewed
May 29, 2019
rwedge
reviewed
May 29, 2019
rwedge
reviewed
May 29, 2019
| try: | ||
| os.makedirs(path) | ||
| except OSError as e: | ||
| if e.errno != errno.EEXIST: |
There was a problem hiding this comment.
could you add a comment describing what EEXIST refers to?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #565
Resolved by adding fixture that creates the path and makes the directory, yields the path, and removes the path folder in the finalization code.