-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Variable Types #571
Conversation
Merge branch 'master' of https://github.com/Featuretools/featuretools into custom_variable_types
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
+ Coverage 96.43% 96.44% +<.01%
==========================================
Files 117 117
Lines 9518 9534 +16
==========================================
+ Hits 9179 9195 +16
Misses 339 339
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Hi @bschreck, we implemented a solution for custom variable types. Would you mind testing out this branch and see if it's working for you? Thanks! |
@allisonportis This works great, thanks for the change! |
Issue #560
Added to entityset/deserialize.py so that description_to_variable() looks at all variables that are (recursively) a subclass of Variable, so that it will recognize custom variable types.