Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty directory tests/synthesis #574

Merged
merged 4 commits into from Jun 3, 2019
Merged

Conversation

CJStadler
Copy link
Contributor

Alternatively, we could rename tests/dfs_tests to tests/synthesis to match featuretools/synthesis.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #574 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files         117      117           
  Lines        9518     9518           
=======================================
  Hits         9179     9179           
  Misses        339      339
Impacted Files Coverage Δ
featuretools/tests/synthesis/test_dfs_method.py 100% <ø> (ø)
...aturetools/tests/synthesis/test_encode_features.py 100% <ø> (ø)
...ols/tests/synthesis/test_deep_feature_synthesis.py 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96303b7...92423e9. Read the comment docs.

@rwedge
Copy link
Contributor

rwedge commented Jun 3, 2019

I like the tests/synthesis idea. Can you move test_encode_features.py into that folder as well, since encode_features is also part of the synthesis module?

Also move test_encode_features.py
…featuretools into remove-empty-synthesis-dir
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CJStadler CJStadler merged commit de1da26 into master Jun 3, 2019
@CJStadler CJStadler deleted the remove-empty-synthesis-dir branch June 3, 2019 15:41
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants