-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renamed features have names correctly serialized #585
Conversation
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
+ Coverage 96.44% 96.46% +0.02%
==========================================
Files 117 117
Lines 9536 9565 +29
==========================================
+ Hits 9197 9227 +30
+ Misses 339 338 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the 1 minor comment, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gsheni and @alexjwang is there anything blocking this? There was just an issue posted about it (#597) so it would be good to get it into the next release if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. merging
fixed #568
Created new branch (same as #580 ) as #580 has commits from #581