Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed features have names correctly serialized #585

Merged
merged 17 commits into from
Jun 13, 2019
Merged

Conversation

alexjwang
Copy link
Contributor

fixed #568

Created new branch (same as #580 ) as #580 has commits from #581

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #585 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   96.44%   96.46%   +0.02%     
==========================================
  Files         117      117              
  Lines        9536     9565      +29     
==========================================
+ Hits         9197     9227      +30     
+ Misses        339      338       -1
Impacted Files Coverage Δ
...ls/tests/primitive_tests/test_identity_features.py 100% <ø> (ø) ⬆️
...aturetools/tests/primitive_tests/test_agg_feats.py 99.35% <ø> (ø) ⬆️
...imitive_tests/test_groupby_transform_primitives.py 100% <ø> (ø) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.32% <ø> (ø) ⬆️
...ools/tests/primitive_tests/test_direct_features.py 100% <ø> (ø) ⬆️
.../tests/primitive_tests/test_features_serializer.py 100% <100%> (ø) ⬆️
...ests/primitive_tests/test_feature_serialization.py 100% <100%> (ø) ⬆️
featuretools/feature_base/features_serializer.py 100% <100%> (ø) ⬆️
featuretools/feature_base/feature_base.py 97.56% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f470ed3...4992ad0. Read the comment docs.

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the 1 minor comment, looks good.

featuretools/feature_base/feature_base.py Outdated Show resolved Hide resolved
gsheni
gsheni previously approved these changes Jun 6, 2019
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CJStadler
Copy link
Contributor

@gsheni and @alexjwang is there anything blocking this? There was just an issue posted about it (#597) so it would be good to get it into the next release if possible.

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. merging

@gsheni gsheni merged commit 11dbb41 into master Jun 13, 2019
@gsheni gsheni deleted the renamed_serialize branch June 13, 2019 14:21
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renamed features do not have their name serialized
3 participants