Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed all mentions of allow_where #587

merged 4 commits into from Jun 6, 2019

removed all mentions of allow_where #587

merged 4 commits into from Jun 6, 2019


Copy link

Fixes #474

allow_where variable in
allow_where variable in
test_allow_where() entire function in

Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #587 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
- Coverage   96.44%   96.43%   -0.01%     
  Files         117      117              
  Lines        9534     9522      -12     
- Hits         9195     9183      -12     
  Misses        339      339
Impacted Files Coverage Δ
...ools/primitives/base/ 100% <ø> (ø) ⬆️
featuretools/synthesis/ 96.74% <ø> (-0.02%) ⬇️
featuretools/primitives/base/ 100% <ø> (ø) ⬆️
...ols/tests/synthesis/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e6d2b...eb0b35a. Read the comment docs.

Copy link

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@alexjwang alexjwang merged commit 8d91985 into master Jun 6, 2019
@gsheni gsheni deleted the remove_allow_where branch June 11, 2019 15:00
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Remove PrimitiveBase.allow_where
2 participants