Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better test function for error checking normalize_entity #590

Merged
merged 5 commits into from Jun 10, 2019

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Jun 10, 2019

  • Added a more clear test for normalize_entity and make_time_index
    • We have an error check for make_time_index to make sure that the column is in copy_variables or additional_variables
    • I rewrote the test cases to more clearly check this, and it uses another entity (customers instead of sessions)

@gsheni gsheni requested a review from rwedge June 10, 2019 16:34
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #590 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   96.43%   96.44%   +<.01%     
==========================================
  Files         117      117              
  Lines        9521     9526       +5     
==========================================
+ Hits         9182     9187       +5     
  Misses        339      339
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_es.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde74cf...3cd58d6. Read the comment docs.

Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the error text mentions the make_time_index must be in additional_variables or copy_variables can we add a test where it's in copy_variables

Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 16bd64a into master Jun 10, 2019
@gsheni gsheni deleted the fix_normalize_check branch June 10, 2019 19:34
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants