Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CI checks into smaller independent jobs #595

Merged
merged 30 commits into from
Jun 21, 2019
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jun 12, 2019

Pull Request Description

This PR will revamp how the CI tests run so that if a one section of tests fails (e.g. the linter) it will still run the other tests to see which sections pass.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #595 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9526     9526           
=======================================
  Hits         9281     9281           
  Misses        245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51d883...665c7da. Read the comment docs.

@rwedge rwedge changed the title [WIP] Separate CI checks into smaller independent jobs Separate CI checks into smaller independent jobs Jun 14, 2019
@kmax12 kmax12 self-requested a review June 21, 2019 16:45
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwedge rwedge merged commit f6ebadc into master Jun 21, 2019
@rwedge rwedge deleted the ci-expand-workflow branch June 21, 2019 18:15
@rwedge rwedge mentioned this pull request Jul 3, 2019
johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019
* separate the py37 CI job into multiple jobs

* fix missing colon in circleci yaml

* use valid job names

* fix wrong command name

* update changelog

* add debug statement for persisting

* fix unpacked naming

* make installd dev reqs job

* add line break

* add dev req job to workflow

* missing colon

* install pandoc in docs job

* try configuring job docker image via workflow

* add other python versions

* remove install dev req job (too much overhead)

* remove dev req jobs from workflow

* remove most custom commands (no longer used multiple times)

* add codecov option to unit test job

* fix indent

* convert package_featuretools from a job to a command

* lint for py36 only

* use py36 for codecov

* lint all python versions

* update changelog

* include docstring tests in unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants