Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of features applied to Index features #602

Merged
merged 3 commits into from Jun 19, 2019
Merged

Change type of features applied to Index features #602

merged 3 commits into from Jun 19, 2019

Conversation

CJStadler
Copy link
Contributor

If the primitive which does not specify a return type is applied to an
Index feature the resulting feature will now have type Categorical, not
Index. There should only be one Index feature per entity.

See #600 (comment)

@CJStadler
Change type of features applied to Index features
beb8423 
If the primitive which does not specify a return type is applied to an
Index feature the resulting feature will now have type Categorical, not
Index. There should only be one Index feature per entity.
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #602 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #602      +/-   ##
=========================================
+ Coverage    96.4%   96.4%   +<.01%     
=========================================
  Files         119     119              
  Lines        9643    9648       +5     
=========================================
+ Hits         9296    9301       +5     
  Misses        347     347
Impacted Files Coverage Δ
featuretools/feature_base/feature_base.py 97.63% <100%> (+0.01%) ⬆️
...retools/tests/primitive_tests/test_feature_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b84b66...beb8423. Read the comment docs.

@CJStadler CJStadler mentioned this pull request Jun 18, 2019
Merged
@codecov-io
Copy link

codecov-io commented Jun 18, 2019 •
edited by codecov bot

Codecov Report

Merging #602 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   96.34%   96.34%   +<.01%     
==========================================
  Files         119      119              
  Lines        9661     9666       +5     
==========================================
+ Hits         9308     9313       +5     
  Misses        353      353
Impacted Files Coverage Δ
featuretools/feature_base/feature_base.py 97.63% <100%> (+0.01%) ⬆️
...retools/tests/primitive_tests/test_feature_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a47d0...a003582. Read the comment docs.

@CJStadler CJStadler requested a review from kmax12 June 18, 2019 17:51
kmax12
kmax12 previously approved these changes Jun 18, 2019
View changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Let's hold off merging until the next release goes out

@CJStadler
Copy link
Contributor Author

@kmax12 is this ready now? (needs to be re-approved)

kmax12
kmax12 approved these changes Jun 19, 2019
View changes
rwedge
rwedge reviewed Jun 19, 2019
View changes
docs/source/changelog.rst
@@ -5,6 +5,7 @@ Changelog
**Future Release**
* Enhancements
* Fixes
* Change type of features calculated on Index features to Categorical (:pr:`602`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be indented more to register as a sublist

@CJStadler CJStadler merged commit 7ed156f into master Jun 19, 2019
@CJStadler CJStadler deleted the feature-type-on-index branch June 19, 2019 20:01
@rwedge rwedge mentioned this pull request Jul 3, 2019
Merged
johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019
@CJStadler
Change type of features applied to Index features (alteryx#602)
57d7cf7 
If a primitive which does not specify a return type is applied to an
Index feature the resulting feature will now have type Categorical, not
Index. There should only be one Index feature per entity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge left review comments

@kmax12 kmax12 kmax12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CJStadler @codecov-io @kmax12 @rwedge