Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change time since return type to numeric #606

merged 2 commits into from Jun 19, 2019


Copy link

@kmax12 kmax12 commented Jun 19, 2019

Currently, the primitive annotation says Timedelta. It should be numeric.

Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #606 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #606   +/-   ##
  Coverage   96.34%   96.34%           
  Files         119      119           
  Lines        9661     9661           
  Hits         9308     9308           
  Misses        353      353
Impacted Files Coverage Δ
...retools/primitives/standard/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26bf38b...0a1420a. Read the comment docs.

Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kmax12 kmax12 merged commit 4659af8 into master Jun 19, 2019
@rwedge rwedge mentioned this pull request Jun 19, 2019
@rwedge rwedge deleted the update-time-since-return_type branch February 19, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants